Make KademliaProtocol public #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riemannulus
previously approved these changes
Dec 22, 2020
moreal
previously approved these changes
Dec 22, 2020
dahlia
reviewed
Dec 22, 2020
Codecov Report
@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 87.63% 87.59% -0.05%
==========================================
Files 345 345
Lines 29956 29956
==========================================
- Hits 26253 26239 -14
- Misses 2073 2087 +14
Partials 1630 1630
|
dahlia
previously approved these changes
Dec 22, 2020
moreal
previously approved these changes
Dec 22, 2020
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
limebell
force-pushed
the
refactor/kademlia
branch
from
13a742c
to
08c3a18
Compare
moreal
approved these changes
Dec 22, 2020
dahlia
approved these changes
Dec 22, 2020
longfin
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change should have been included in #1120, but omitted by mistake.