Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn into parameter in BlockPolicy's constructor to milliseconds #151

Merged
merged 2 commits into from Mar 24, 2019

Conversation

Projects
None yet
3 participants
@jckdotim
Copy link
Contributor

commented Mar 23, 2019

This PR turns BlockPolicy's constructor parameter into milliseconds.
(closes #104)

@jckdotim jckdotim requested review from dahlia and longfin Mar 23, 2019

jckdotim added a commit to jckdotim/libplanet that referenced this pull request Mar 23, 2019

@jckdotim jckdotim self-assigned this Mar 23, 2019

@jckdotim jckdotim modified the milestone: 0.2.0 Mar 23, 2019

@longfin

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

@jckdotim Thanks for patch.

it seems that this branch is out of date. could you rebase it?

@jckdotim jckdotim force-pushed the jckdotim:issue-104 branch from 853932d to e7fc8ac Mar 23, 2019

@dahlia

dahlia approved these changes Mar 23, 2019

@jckdotim jckdotim merged commit 22f90ce into planetarium:master Mar 24, 2019

5 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.