-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump target framework to 6.0 for test projects #2173
Conversation
7b9a3e7
to
bb539b0
Compare
a820bce
to
1096cc7
Compare
@@ -119,15 +119,15 @@ commands: | |||
- run: | | |||
msbuild \ | |||
-t:Restore \ | |||
-p:Configuration=Release \ | |||
-p:Configuration=ReleaseMono \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this purpose to merely have a separated output directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually for excluding Libplanet.Explorer*
projects from being compiled on Mono target. This is implemented via having a new ReleaseMono
build target on the solution and excluding specific projects from the target, and then using the build target on Mono.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, could you mention that in CONTRIBUTING.md file?
Notes: When `Libplanet.Explorer` project is set to target `net6.0`, it requires `6.x` version of `Microsoft.AspNetCore.Mvc.NewtonsoftJson` package. However, since MSBuild bundled with Mono cannot correctly interpret `net6.0` moniker, it is impossible to build the project with mono. For this, a new target `ReleaseMono` was set up to specifically exclude `Libplanet.Explorer*` projects from being built with mono. With `netcoreapp3.1`, only the executable produced with `dotnet publish` was marked executable. However, with `net6.0`, all the produced binaries are marked executable. Because of this, `bin_name` had to be produced in another way, which at the moment is looking whether it has `o+x` (or `g+x`) permission.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Resolves #2164. Resolves #2090.
To fully drop 3.1,
Libplanet
,Libplanet.Analyzers
,Libplanet.Net
,Libplanet.Stun
, andLibplanet.Tools
projects also has to be bumped to 6.0.Note: When
Libplanet.Explorer
project is set to targetnet6.0
, it requires6.x
version ofMicrosoft.AspNetCore.Mvc.NewtonsoftJson
package. However, since MSBuild bundled with Mono cannot correctly interpretnet6.0
moniker, it is impossible to build the project with mono. For this, a new targetReleaseMono
was set up to specifically excludeLibplanet.Explorer*
projects from being built with mono.Note 2: With
netcoreapp3.1
, only the executable produced withdotnet publish
was marked executable. However, withnet6.0
, all the produced binaries are marked executable. Because of this,bin_name
had to be produced in another way, which at the moment is looking whether it haso+x
(org+x
) permission.