Fixed a bug in BlockChain<T>.GetNextTxNonce #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 86.64% 86.64% +<.01%
==========================================
Files 221 221
Lines 18681 18685 +4
==========================================
+ Hits 16186 16190 +4
Misses 1338 1338
Partials 1157 1157
|
earlbread
previously approved these changes
Dec 11, 2019
limebell
force-pushed
the
bugfix/get-next-tx-nonce
branch
from
ddfe20e
to
082cf6a
Compare
limebell
force-pushed
the
bugfix/get-next-tx-nonce
branch
from
082cf6a
to
08d6928
Compare
earlbread
approved these changes
Dec 11, 2019
longfin
approved these changes
Dec 11, 2019
moreal
approved these changes
Dec 11, 2019
dahlia
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had returned duplicated tx nonce when
prevNonceis in staged transactions somehow.