Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in BlockChain<T>.GetNextTxNonce #718

Merged
merged 2 commits into from Dec 11, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Dec 11, 2019

It had returned duplicated tx nonce when prevNonce is in staged transactions somehow.

@limebell limebell requested review from dahlia, longfin, earlbread and moreal Dec 11, 2019
@limebell limebell self-assigned this Dec 11, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #718 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   86.64%   86.64%   +<.01%     
==========================================
  Files         221      221              
  Lines       18681    18685       +4     
==========================================
+ Hits        16186    16190       +4     
  Misses       1338     1338              
  Partials     1157     1157
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.65% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 90.88% <100%> (ø) ⬆️
@limebell limebell force-pushed the limebell:bugfix/get-next-tx-nonce branch from ddfe20e to 082cf6a Dec 11, 2019
@limebell limebell force-pushed the limebell:bugfix/get-next-tx-nonce branch from 082cf6a to 08d6928 Dec 11, 2019
@limebell limebell requested a review from earlbread Dec 11, 2019
@moreal
moreal approved these changes Dec 11, 2019
@dahlia
dahlia approved these changes Dec 11, 2019
@longfin longfin merged commit d6f49a1 into planetarium:master Dec 11, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 86.64%)
Details
codecov/project 86.64% (+<.01%) compared to 5dcfe5c
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191211.3 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.