Ability to define resources for init containers #212
Comments
brandt
added a commit
to brandt/vitess-operator
that referenced
this issue
Mar 6, 2022
Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself. This fixes the issue reported in planetscale#212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers. ## History This is a reimplementation of planetscale#216 with the change that it no longer sets a default resource _limit_. This fixes the issue reported in planetscale#240 and discussed in planetscale#244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because `update.ResourceRequirements(dst, src)` won't update `dst` with a nil `src` ([for good reasons](https://github.com/planetscale/vitess-operator/blob/da7efd4c945193864f5996cb793055449c4de97a/pkg/operator/update/podspec.go#L201-L203)). With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit. fixes planetscale#212 fixes planetscale#240 Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com>
GuptaManan100
pushed a commit
that referenced
this issue
Feb 2, 2023
Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself. This fixes the issue reported in #212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers. ## History This is a reimplementation of #216 with the change that it no longer sets a default resource _limit_. This fixes the issue reported in #240 and discussed in #244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because `update.ResourceRequirements(dst, src)` won't update `dst` with a nil `src` ([for good reasons](https://github.com/planetscale/vitess-operator/blob/da7efd4c945193864f5996cb793055449c4de97a/pkg/operator/update/podspec.go#L201-L203)). With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit. fixes #212 fixes #240 Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com>
GuptaManan100
added a commit
that referenced
this issue
Feb 2, 2023
* Set vttablet init container resource requests and limits Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself. This fixes the issue reported in #212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers. ## History This is a reimplementation of #216 with the change that it no longer sets a default resource _limit_. This fixes the issue reported in #240 and discussed in #244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because `update.ResourceRequirements(dst, src)` won't update `dst` with a nil `src` ([for good reasons](https://github.com/planetscale/vitess-operator/blob/da7efd4c945193864f5996cb793055449c4de97a/pkg/operator/update/podspec.go#L201-L203)). With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit. fixes #212 fixes #240 Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com> * refactor: move defaults to the correct location Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: J. Brandt Buckley <brandt@runlevel1.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The init containers
init-vt-rootandinit-mysql-socket(and possibly others) do not specify any resource requests or limits. In some cluster setups with strict quota requirements this can prevent a pod from being created.The ability to define these resources would allow the operator to function properly in such clusters.
The text was updated successfully, but these errors were encountered: