Set vttablet init container resource requests and limits #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself. This fixes the issue reported in planetscale#212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers. ## History This is a reimplementation of planetscale#216 with the change that it no longer sets a default resource _limit_. This fixes the issue reported in planetscale#240 and discussed in planetscale#244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because `update.ResourceRequirements(dst, src)` won't update `dst` with a nil `src` ([for good reasons](https://github.com/planetscale/vitess-operator/blob/da7efd4c945193864f5996cb793055449c4de97a/pkg/operator/update/podspec.go#L201-L203)). With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit. fixes planetscale#212 fixes planetscale#240 Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com>
|
@brandt There are others better suited for the review, but I just wanted to say THANK YOU for the contribution! It's really nice to see non-PlanetScale contributors to the operator. ❤️ |
|
@mattlord My pleasure! |
Comment on lines
+52
to
+53
| defaultInitCPURequestMillis = 100 | ||
| defaultInitMemoryRequestBytes = 32 * (1 << 20) // 32 MiB |
There was a problem hiding this comment.
Default values live here https://github.com/planetscale/vitess-operator/blob/main/pkg/apis/planetscale/v2/defaults.go, and so should these.
|
@brandt Are you still working on this? We would like to get this change in before we do the next release. |
|
Closed in favour of #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself.
This fixes the issue reported in #212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers.
History
This is a reimplementation of #216 with the change that it no longer sets a default resource limit.
This fixes the issue reported in #240 and discussed in #244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because
update.ResourceRequirements(dst, src)won't updatedstwith a nilsrc(for good reasons).With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit.
fixes #212
fixes #240
Signed-off-by: J. Brandt Buckley brandt@runlevel1.com