Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto3 optional field support #2

Closed
jbub opened this issue Jun 4, 2021 · 2 comments · Fixed by #5
Closed

Proto3 optional field support #2

jbub opened this issue Jun 4, 2021 · 2 comments · Fixed by #5

Comments

@jbub
Copy link

jbub commented Jun 4, 2021

Hello, i have just tried running this generator on my proto3 files and it failed with:

myproto.proto is a proto3 file that contains optional fields, but code generator protoc-gen-go-vtproto hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--go-vtproto_out:

Is optional field supported by this generator ?

Thanks
@vmg
Copy link
Member

vmg commented Jun 7, 2021

This is probably a legitimate bug. Let me see how involved it is to fix.

@vmg vmg mentioned this issue Jun 7, 2021
Merged
@vmg
Copy link
Member

vmg commented Jun 7, 2021

This was more involved than I thought. Feature is implemented in #5 -- please test it on your local codebases. Vitess does not use optional fields at all.

@vmg vmg closed this as completed in #5 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: add support for optional fields in proto3 planetscale/vtprotobuf
2 participants
@vmg @jbub