Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in Planka #13

Open
sargas opened this issue May 31, 2020 · 6 comments
Open

Tests in Planka #13

sargas opened this issue May 31, 2020 · 6 comments

Comments

@sargas
Copy link

sargas commented May 31, 2020

Hello @meltyshev ,

I may submit a PR, and since there is no CONTRIBUTING doc, I was hoping you could answer if a PR that added test cases for new feature(s) would be acceptable. If so, I also wanted to ask beforehand if there are any test runners / assertions libraries / frameworks / etc you are opinionated about?

Thanks

@meltyshev
Copy link
Member

Hi, @sargas,

Currently, it takes a long time to test all features by hand, so it will be nice to start writing tests. To be honest, I not very familiar with test libs, but I heard about Jest - I think it should be enough and it's easy to use. Sorry about no CONTRIBUTING doc, I definitely should add it.

Thank you!

@gempain
Copy link

gempain commented Aug 13, 2020

@meltyshev jest is a really good choice. You'll get more people able to contribute. Really easy to setup :) For UI testing, have you considered Cypress ?

@meltyshev
Copy link
Member

@gempain already reading about it 😀 I will add these test libs to the project in the next commit...

@meltyshev meltyshev pinned this issue Aug 20, 2020
@meltyshev
Copy link
Member

meltyshev commented Aug 20, 2020

Test libs already there. Also added two example test files: server, client. Still don't have time for CONTRIBUTING doc, so I just pinned this issue. Cypress or something similar will be added a bit later...

@adj2908
Copy link

adj2908 commented Sep 1, 2022

Hi @meltyshev,
I would like to contribute to this by writing cypress tests. Please let me know what should be the next approach before I start working on it.

Thanks,
Aditya

@meltyshev
Copy link
Member

Hi! First we need to add Cypress. I can try to figure it out soon, or please do a PR 🙏

@meltyshev meltyshev unpinned this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants