Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register clients before plugins #2255

Conversation

mikaelkaron
Copy link
Contributor

Fixes: #2254

@mcollina
Copy link
Member

Can you add a test?

@mikaelkaron mikaelkaron force-pushed the mikaelkaron-client-register-before-plugins branch from 39503c3 to 82d54b4 Compare March 12, 2024 17:11
Fixes: platformatic#2254

Signed-off-by: Mikael Karon <mikael@karon.se>
Signed-off-by: Mikael Karon <mikael@karon.se>
@mikaelkaron mikaelkaron force-pushed the mikaelkaron-client-register-before-plugins branch from 82d54b4 to 8d48e6b Compare March 12, 2024 17:11
Signed-off-by: Mikael Karon <mikael@karon.se>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6c4ee65 into platformatic:main Mar 13, 2024
87 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients are registred after plugins
2 participants