Register clients before plugins

packages/service/fixtures/hello-client-from-plugin/hello.d.ts

@@ -0,0 +1,34 @@
+import { FastifyPluginAsync } from 'fastify'
+
+interface GetRequest {
+}
+
+interface GetResponse {
+}
+
+interface Hello {
+  get(req: GetRequest): Promise<GetResponse>;
+}
+
+type HelloPlugin = FastifyPluginAsync<NonNullable<hello.HelloOptions>>
+
+declare module 'fastify' {
+  interface FastifyInstance {
+    'hello': Hello;
+  }
+
+  interface FastifyRequest {
+    'hello': Hello;
+  }
+}
+
+declare namespace hello {
+  export interface HelloOptions {
+    url: string
+  }
+  export const hello: HelloPlugin;
+  export { hello as default };
+}
+
+declare function hello(...params: Parameters<HelloPlugin>): ReturnType<HelloPlugin>;
+export = hello;

packages/service/fixtures/hello-client-from-plugin/hello.openapi.json

@@ -0,0 +1,22 @@
+{
+  "openapi": "3.0.3",
+  "info": {
+    "title": "Platformatic",
+    "description": "This is a service built on top of Platformatic",
+    "version": "1.0.0"
+  },
+  "components": {
+    "schemas": {}
+  },
+  "paths": {
+    "/": {
+      "get": {
+        "responses": {
+          "200": {
+            "description": "Default Response"
+          }
+        }
+      }
+    }
+  }
+}

packages/service/fixtures/hello-client-from-plugin/platformatic.service.json

@@ -0,0 +1,21 @@
+{
+  "server": {
+    "hostname": "127.0.0.1",
+    "port": 0,
+    "logger": {
+      "level": "warn",
+      "name": "hello client"
+    }
+  },
+  "plugins": {
+    "paths": ["./plugin.js"]
+  },
+  "clients": [{
+    "schema": "./hello.openapi.json",
+    "name": "hello",
+    "type": "openapi",
+    "url": "{PLT_CLIENT_URL}"
+  }],
+  "metrics": false,
+  "watch": false
+}

packages/service/fixtures/hello-client-from-plugin/plugin.js

@@ -0,0 +1,9 @@
+'use default'
+
+/**  @type {import('fastify').FastifyPluginAsync<{ optionA: boolean, optionB: string }>} */
+module.exports = async function (app) {
+  const result = app.hello.get()
+  app.get('/', async () => {
+    return result
+  })
+}

packages/service/index.js

@@ -42,6 +42,12 @@ async function platformaticService (app, opts) {
     await app.register(telemetry, config.telemetry)
   }
 
+  // This must be done before loading the plugins, so they can be
+  // configured accordingly
+  if (isKeyEnabled('clients', config)) {
+    app.register(setupClients, config.clients)
+  }
+
   if (Array.isArray(beforePlugins)) {
     for (const plugin of beforePlugins) {
       app.register(plugin)
@@ -83,10 +89,6 @@ async function platformaticService (app, opts) {
     }
   })
 
-  if (isKeyEnabled('clients', config)) {
-    app.register(setupClients, config.clients)
-  }
-
   if (isKeyEnabled('cors', config.server)) {
     app.register(setupCors, config.server.cors)
   }

packages/service/test/clients.test.js

@@ -87,3 +87,26 @@
   const data = await res.body.json()
   assert.deepStrictEqual(data, { hello: 'world' })
 })
+
+test('client is loaded before plugins', async (t) => {
+  const app1 = await buildServer(join(__dirname, '..', 'fixtures', 'hello', 'warn-log.service.json'))
+
+  t.after(async () => {
+    await app1.close()
+  })
+  await app1.start()
+
+  process.env.PLT_CLIENT_URL = app1.url
+
+  const app2 = await buildServer(join(__dirname, '..', 'fixtures', 'hello-client-from-plugin', 'platformatic.service.json'))
+
+  t.after(async () => {
+    await app2.close()
+  })
+  await app2.start()
+
+  const res = await request(`${app2.url}/`)
+  assert.strictEqual(res.statusCode, 200, 'status code')
+  const data = await res.body.json()
+  assert.deepStrictEqual(data, { hello: 'world' })
+})