Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): Enhance error handling enum type #508

Conversation

rozzilla
Copy link
Contributor

Related to this issue, this code change enables to add more logging info in case of an error generating the GraphQLEnumType.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! As a reminder: we have a logger, don't use console.log.

packages/sql-graphql/lib/entity-to-type.js Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

This needs a DCO remediation commit

@rozzilla rozzilla force-pushed the feat/enhance-error-handling-enum-type-error branch from 13f0c8e to 3d04c5d Compare December 18, 2022 21:20
rozzilla and others added 2 commits December 18, 2022 22:21
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianki@gmail.com>
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Roberto Bianchi <roberto.bianki@gmail.com>
@rozzilla rozzilla force-pushed the feat/enhance-error-handling-enum-type-error branch from 3d04c5d to d56be74 Compare December 18, 2022 21:21
@rozzilla
Copy link
Contributor Author

This needs a DCO remediation commit

Done, we can merge it 😉

@mcollina mcollina merged commit 5fab236 into platformatic:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants