Setup Dashboard on custom endpoint #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
leorossi
force-pushed
the
feat/dashboard-custom-endpoint
branch
from
810255c
to
6fcb7e0
Compare
mcollina
reviewed
Feb 8, 2023
packages/db-dashboard/index.js
Outdated
| }) | ||
| // app.get(`${dashboardPath}/*`, { hide: true }, function (req, reply) { | ||
| // return reply.sendFile('index.html') | ||
| // }) |
There was a problem hiding this comment.
fastify-static gives me the error of #560 , I'm looking how to solve this
|
I think this also solves #560 |
|
@leorossi could you fix linting? |
Closed
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
|
Ended up a bit more complicated, because the react app relied on the I added a script that fixes the |
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcollina this may be a breaking change in configuration because I renamed
dashboard.rootPathtodashboard.pathand that would be a string.@Eomm I used the
{ path: ... }pattern to be consistent with thepluginsconfigurationLet me know what you think
Fixes #657
Signed-off-by: Leonardo Rossi leonardo.rossi@gmail.com