Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(service): Improve error message #765

Merged
merged 2 commits into from
Mar 12, 2023
Merged

chore(service): Improve error message #765

merged 2 commits into from
Mar 12, 2023

Conversation

rozzilla
Copy link
Contributor

Related to #523, this PR changes the error message from Missing config file to:

Missing config file!
Be sure to have a config file with one of the following names: platformatic.service.json
platformatic.service.json5
platformatic.service.yaml
platformatic.service.yml
platformatic.service.toml
platformatic.service.tml
In alternative run "npm create platformatic@latest" to generate a basic plt service config.
Error: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

@mcollina
Copy link
Member

Could you rebase?

@rozzilla
chore(service): Improve error message
78ce9d5 
Signed-off-by: Roberto Bianchi <roberto.bianki@gmail.com>
@rozzilla
use single quote
5ce0230 
Signed-off-by: Roberto Bianchi <roberto.bianki@gmail.com>
@rozzilla rozzilla force-pushed the chore/service/improve-error-message branch from ce96591 to 5ce0230 Compare March 11, 2023 11:52
@rozzilla
Copy link
Contributor Author

Could you rebase?

Done ✅
Tests are failing but for external reasons:

  1. uncovered tested lines 53-54,101-108 on service/index.js
  2. pnpm: EBUSY: resource busy or locked copyfile 'D:\.pnpm-store\v3\files\...' -> 'D:\a\platformatic\platformatic\node_modules\.pnpm\@swagger-api+apidom-parser-adapter-openapi-yaml-3-1@0.69.0\node_modules\@swagger-api\...\cjs\adapter.cjs' Error: Process completed with exit code 1

@rozzilla rozzilla mentioned this pull request Mar 11, 2023
Merged
mcollina
mcollina approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 63769a1 into platformatic:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozzilla @mcollina