-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update programlib #4363
Update programlib #4363
Conversation
I think a first step we should take is consider moving /program-lib folder outside of the graphics. It this it should standalone, one level up from graphics, on the same level as the /scene. Currently it is in graphics, but uses many constants and even few modules the scene. And consider how this works out after that. I'm not convinced the GraphicsDevice should own the builders library. Graphics device should be a user of generated shaders, but don't be part of the generation itself. |
Yep totally agree. Also Device owns ProgramLibrary and ProgramLibrary keeps device :( What this PR is doing is -not- registering random shader chunks as programs (by not using programlib for this) without potentially breaking existing projects. |
This PR:
programlib
objectdevice
object from StandardMaterialOptionsBuilderProgramLibrary
test with SHADER_ defines updated in Utility private ShaderPass class to abstract some code scattered in the codebase #4328