Utility private ShaderPass class to abstract some code scattered in the codebase #4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSterbrant
reviewed
Jun 14, 2022
|
This is so much better! Though TBH I'm now wondering why we store the precise type of shadow generation as a parse! Seems like SHADER_PARSE should be 'shadow depth' and the shadow type should be stored separately. This would simplify all the code that does parse-specific logic. |
|
(This is actually a question @mvaligursky - what do you think?) |
|
we generate different shadow rendering shaders based on those passes, and store them in an array of shader variants both in material and mesh instance - so its convenient to have a single index for all shader variants (shadow or otherwise) |
GSterbrant
approved these changes
Jun 14, 2022
Co-authored-by: Will Eastcott <will@playcanvas.com>
willeastcott
added
bug
area: graphics
slimbuck
approved these changes
Jun 14, 2022
willeastcott
approved these changes
Jun 14, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4325 (does not handle the renaming part yet)