Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failed] play-grpc samples on 2.7.x branch fail run on JDK8u252 #102

Closed
ignasi35 opened this issue May 20, 2020 · 2 comments
Closed

[Failed] play-grpc samples on 2.7.x branch fail run on JDK8u252 #102

ignasi35 opened this issue May 20, 2020 · 2 comments
Labels

Comments

@ignasi35
Copy link
Member

Despite bumping to the samples to Play 2.7.5 in #100, the gRPC samples still depend on an old play-grpc/akka-grpc combo which, I suspect, is transitively bringing in the wrong akka-http/netty artifacts (artifacts not compatible with JDK8u252).

@ignasi35
Copy link
Member Author

  // project/plugins.sbt                                                                                                                                                                  
- addSbtPlugin("com.lightbend.akka.grpc" %% "sbt-akka-grpc" % "0.6.2")                                                                                                                    
+ addSbtPlugin("com.lightbend.akka.grpc" %% "sbt-akka-grpc" % "0.8.4")                                                                                                                    
+ resolvers += Resolver.bintrayRepo("playframework", "maven")                                                                                                                             
+ libraryDependencies += "com.lightbend.play" %% "play-grpc-generators" % "0.8.2"                                                                                                         

and pull the thread...

@mkurz
Copy link
Member

mkurz commented Mar 4, 2023

Fixed already, also Play 2.7 is eol.

@mkurz mkurz closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants