Remove unused netty settings #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Nov 22, 2019
octonato
added a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
* Updated with template-control on 2018-11-29T15:50:43.241Z
/.mergify.yml:
wrote /.mergify.yml
**build.sbt:
scalaVersion := "2.12.7"
* Remove JDK 9 & 10
octonato
added a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
* Updated with template-control on 2018-11-29T15:50:43.464Z
/.mergify.yml:
wrote /.mergify.yml
**build.sbt:
scalaVersion := "2.12.7"
* Remove JDK 9 & 10
octonato
added a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…2.6.x Upgrade branch 2.6.x using TemplateControl
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
….6.x * play-java-starter-example/2.6.x: (57 commits) Nest play-java-starter-example Updated with template-control on 2019-02-13T20:25:39.664Z (playframework#103) Upgrade branch 2.6.x using TemplateControl (playframework#99) Upgrade branch 2.6.x using TemplateControl (playframework#98) Upgrade branch 2.6.x using TemplateControl (playframework#97) Updated with template-control on 2019-01-08T14:44:42.254Z (playframework#95) Updated with template-control on 2019-01-04T17:13:24.036Z (playframework#90) Upgrade branch 2.6.x using TemplateControl (playframework#89) Improve README (playframework#81) Upgrade branch 2.6.x using TemplateControl (playframework#79) Updated with template-control on 2018-09-11T20:14:50.628Z (playframework#78) Updated with template-control on 2018-08-20T20:37:14.072Z (playframework#77) Updated with template-control on 2018-07-19T01:58:56.147Z (playframework#74) Updated with template-control on 2018-07-16T18:38:45.658Z (playframework#73) Upgrade branch 2.6.x using TemplateControl (playframework#71) Updated with template-control on 2018-05-27T23:54:09.356Z (playframework#69) Updated with template-control on 2018-04-06T19:34:58.808Z (playframework#66) Change disabled to enabled (playframework#64) Use discuss forum (playframework#62) Enable localhost:9000 as allowed host by default. (playframework#61) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
… 2.6.x * play-java-streaming-example/2.6.x: (45 commits) Nest play-java-streaming-example Updated with template-control on 2019-02-13T20:25:39.687Z (playframework#81) Upgrade branch 2.6.x using TemplateControl (playframework#79) Upgrade branch 2.6.x using TemplateControl (playframework#78) Upgrade branch 2.6.x using TemplateControl (playframework#77) Updated with template-control on 2019-01-08T14:44:41.668Z (playframework#75) Updated with template-control on 2019-01-04T17:13:23.629Z (playframework#70) Upgrade branch 2.6.x using TemplateControl (playframework#69) Upgrade branch 2.6.x using TemplateControl (playframework#66) Updated with template-control on 2018-09-11T20:14:50.512Z (playframework#65) Updated with template-control on 2018-08-20T20:37:13.644Z (playframework#64) Updated with template-control on 2018-07-19T01:58:55.832Z (playframework#62) Updated with template-control on 2018-07-16T18:38:45.449Z (playframework#61) Upgrade branch 2.6.x using TemplateControl (playframework#60) Updated with template-control on 2018-05-27T23:54:09.459Z (playframework#59) Updated with template-control on 2018-04-06T19:34:58.233Z (playframework#57) Updated with template-control on 2018-03-02T18:56:28.174Z (playframework#56) Upgrade branch 2.6.x using TemplateControl (playframework#55) Fix cross build to sbt 1.1.0 (playframework#54) Upgrade branch 2.6.x using TemplateControl (playframework#53) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…to 2.6.x * play-scala-compile-di-example/2.6.x: (66 commits) Nest play-scala-compile-di-example Updated with template-control on 2019-02-13T20:25:39.413Z (playframework#87) Updated with template-control on 2019-02-01T10:40:33.389Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-17T15:10:58.005Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.884Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml **build.gradle: playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2" Updated with template-control on 2019-01-08T14:44:42.104Z (playframework#81) Updated with template-control on 2019-01-04T17:13:23.804Z (playframework#76) Drop oraclejdk10 Updated with template-control on 2018-11-29T15:50:43.529Z /.mergify.yml: wrote /.mergify.yml **build.sbt: scalaVersion := "2.12.7" Made minor changes to the README file documentation Updated with template-control on 2018-10-08T19:11:41.162Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Updated with template-control on 2018-09-11T20:14:49.815Z (playframework#69) Updated with template-control on 2018-08-20T20:37:13.694Z (playframework#68) Updated with template-control on 2018-07-19T01:58:55.403Z (playframework#66) Updated with template-control on 2018-07-16T18:38:45.033Z (playframework#65) Upgrade branch 2.6.x using TemplateControl (playframework#64) Updated with template-control on 2018-05-27T23:54:09.150Z (playframework#63) Updated with template-control on 2018-04-06T19:34:58.408Z (playframework#61) Updated with template-control on 2018-03-02T18:56:27.945Z (playframework#60) Upgrade branch 2.6.x using TemplateControl (playframework#59) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…to 2.6.x * play-scala-fileupload-example/2.6.x: (50 commits) Nest play-scala-fileupload-example Updated with template-control on 2019-02-13T20:25:39.491Z (playframework#78) Updated with template-control on 2019-02-01T10:40:33.510Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-17T15:10:57.985Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.799Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml **build.gradle: playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2" Updated with template-control on 2019-01-08T14:44:41.664Z (playframework#72) Updated with template-control on 2019-01-04T17:13:23.928Z (playframework#67) Upgrade branch 2.6.x using TemplateControl (playframework#66) Updated with template-control on 2018-10-08T19:11:40.600Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Update application.conf (playframework#62) Updated with template-control on 2018-09-11T20:14:49.954Z (playframework#61) Updated with template-control on 2018-08-20T20:37:13.724Z (playframework#60) Updated with template-control on 2018-07-19T01:58:55.837Z (playframework#58) Updated with template-control on 2018-07-16T18:38:45.429Z (playframework#57) Upgrade branch 2.6.x using TemplateControl (playframework#56) Updated with template-control on 2018-05-27T23:54:09.258Z (playframework#55) Updated with template-control on 2018-04-06T19:34:57.720Z (playframework#53) Update application.conf Update application.conf Add explicit file upload limit ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…to 2.6.x * play-scala-macwire-di-example/2.6.x: (65 commits) Nest play-scala-macwire-di-example Updated with template-control on 2019-02-13T20:25:39.672Z (playframework#82) Updated with template-control on 2019-02-01T10:40:33.270Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-17T15:10:57.898Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:46.033Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml **build.gradle: playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2" Updated with template-control on 2019-01-08T14:44:44.697Z (playframework#76) Updated with template-control on 2019-01-04T17:13:23.938Z (playframework#71) Upgrade branch 2.6.x using TemplateControl (playframework#70) Updated with template-control on 2018-10-08T19:11:40.533Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Updated with template-control on 2018-09-11T20:14:50.619Z (playframework#66) Updated with template-control on 2018-08-20T20:37:13.853Z (playframework#65) Updated with template-control on 2018-07-19T01:58:55.845Z (playframework#63) Updated with template-control on 2018-07-16T18:38:45.430Z (playframework#62) Upgrade branch 2.6.x using TemplateControl (playframework#61) Updated with template-control on 2018-05-27T23:54:10.362Z (playframework#60) Updated with template-control on 2018-04-06T19:34:59.235Z (playframework#58) Updated with template-control on 2018-03-02T18:56:30.403Z (playframework#57) Upgrade branch 2.6.x using TemplateControl (playframework#56) Fix cross build to sbt 1.1.0 (playframework#55) Upgrade branch 2.6.x using TemplateControl (playframework#54) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…' into 2.6.x * play-scala-secure-session-example/2.6.x: (70 commits) Nest play-scala-secure-session-example Updated with template-control on 2019-02-13T20:17:46.435Z (playframework#95) Updated with template-control on 2019-02-01T10:40:32.758Z (playframework#93) Upgrade branch 2.6.x using TemplateControl (playframework#92) Upgrade branch 2.6.x using TemplateControl (playframework#91) Upgrade branch 2.6.x using TemplateControl (playframework#89) Upgrade branch 2.6.x using TemplateControl (playframework#82) Upgrade branch 2.6.x using TemplateControl (playframework#81) adds mergify file (playframework#79) Upgrade branch 2.6.x using TemplateControl (playframework#77) Updated with template-control on 2018-08-20T20:37:13.861Z (playframework#71) Updated with template-control on 2018-07-19T01:58:55.998Z (playframework#69) Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#68) Upgrade branch 2.6.x using TemplateControl (playframework#66) Updated with template-control on 2018-05-27T23:54:09.617Z (playframework#65) Updated with template-control on 2018-04-06T19:34:58.475Z (playframework#63) Updated with template-control on 2018-03-02T18:56:28.210Z (playframework#62) Upgrade branch 2.6.x using TemplateControl (playframework#61) Fix cross build to sbt 1.1.0 (playframework#60) Upgrade branch 2.6.x using TemplateControl (playframework#59) ...
octonato
pushed a commit
to octonato/play-samples
that referenced
this pull request
Dec 4, 2019
…o 2.6.x * play-scala-streaming-example/2.6.x: (52 commits) Nest play-scala-streaming-example Updated with template-control on 2019-02-13T20:25:39.555Z (playframework#77) Upgrade branch 2.6.x using TemplateControl (playframework#75) Upgrade branch 2.6.x using TemplateControl (playframework#74) Upgrade branch 2.6.x using TemplateControl (playframework#73) Updated with template-control on 2019-01-08T14:44:41.633Z (playframework#71) Updated with template-control on 2019-01-04T17:13:23.822Z (playframework#67) Upgrade branch 2.6.x using TemplateControl (playframework#66) Upgrade branch 2.6.x using TemplateControl (playframework#63) Updated with template-control on 2018-09-11T20:14:50.169Z (playframework#62) Updated with template-control on 2018-08-20T20:37:13.651Z (playframework#60) Updated with template-control on 2018-07-16T18:38:45.481Z (playframework#59) Upgrade branch 2.6.x using TemplateControl (playframework#58) Updated with template-control on 2018-05-27T23:54:09.895Z (playframework#57) Updated with template-control on 2018-04-06T19:34:57.566Z (playframework#56) current -> latest (playframework#55) Updated with template-control on 2018-03-02T18:56:28.085Z (playframework#54) Upgrade branch 2.6.x using TemplateControl (playframework#53) Fix cross build to sbt 1.1.0 (playframework#52) Upgrade branch 2.6.x using TemplateControl (playframework#51) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though #44 states we should replace these settings with Akka HTTP values, I think removing the Netty ones (Currently unused on those samples) is enough.
Fixes #44