Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port play-java-websocket-example to Akka Typed #63

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Port play-java-websocket-example to Akka Typed #63

merged 3 commits into from
Nov 18, 2019

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Nov 8, 2019

No description provided.

@dwijnand dwijnand requested a review from a team November 8, 2019 17:57
@marcospereira marcospereira mentioned this pull request Nov 8, 2019
Closed
34 tasks
@dwijnand dwijnand mentioned this pull request Nov 16, 2019
Closed
39 tasks
ignasi35
ignasi35 reviewed Nov 18, 2019
View reviewed changes
Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I find it weird this sample doesn't have the postStop issue like the scala one

@ignasi35 ignasi35 merged commit a76838f into playframework:2.8.x Nov 18, 2019
@dwijnand dwijnand deleted the typed-porting-java branch November 18, 2019 20:47
octonato added a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@octonato
Merge pull request playframework#63 from renatocaval/templatecontrol-…
5e2b252 
…2.6.x

Upgrade branch 2.6.x using TemplateControl
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-ebean-example/2.6.x' into 2.6.x
ff17d4f 
* play-java-ebean-example/2.6.x: (52 commits)
  Nest play-java-ebean-example
  Updated with template-control on 2019-02-13T20:25:39.252Z (playframework#96)
  Upgrade branch 2.6.x using TemplateControl (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#92)
  Updated with template-control on 2019-01-08T14:44:41.376Z (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#83)
  Upgrade branch 2.6.x using TemplateControl (playframework#79)
  Updated with template-control on 2018-09-11T20:14:50.116Z (playframework#77)
  Updated with template-control on 2018-08-20T20:37:13.842Z (playframework#76)
  Updated with template-control on 2018-07-19T01:58:55.623Z (playframework#74)
  Updated with template-control on 2018-07-16T18:38:45.357Z (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#72)
  Updated with template-control on 2018-05-27T23:54:09.409Z (playframework#71)
  Updated with template-control on 2018-04-06T19:34:58.195Z (playframework#68)
  Updated with template-control on 2018-03-02T18:56:28.219Z (playframework#67)
  Updated with template-control on 2018-01-11T21:32:27.151Z (playframework#64)
  Fix cross build to sbt 1.1.0 (playframework#63)
  Updated with template-control on 2018-01-09T20:17:10.839Z (playframework#62)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-java-jpa-example/2.6.x' into 2.6.x
3d9fb36 
* play-java-jpa-example/2.6.x: (48 commits)
  Nest play-java-jpa-example
  Updated with template-control on 2019-02-13T20:25:39.298Z (playframework#87)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#84)
  Upgrade branch 2.6.x using TemplateControl (playframework#83)
  Updated with template-control on 2019-01-08T14:44:42.531Z (playframework#81)
  Updated with template-control on 2019-01-04T17:13:23.827Z (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#71)
  Upgrade branch 2.6.x using TemplateControl (playframework#69)
  Updated with template-control on 2018-09-11T20:14:50.333Z (playframework#65)
  Updated with template-control on 2018-08-20T20:37:13.878Z (playframework#63)
  Updated with template-control on 2018-07-19T01:58:55.873Z (playframework#61)
  Updated with template-control on 2018-07-16T18:38:45.441Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  Updated with template-control on 2018-05-27T23:54:09.603Z (playframework#58)
  Updated with template-control on 2018-04-06T19:34:58.092Z (playframework#55)
  Updated with template-control on 2018-03-02T18:56:28.087Z (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#53)
  Fix cross build to sbt 1.1.0 (playframework#52)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-compile-di-example/2.6.x' in…
8903bb9 
…to 2.6.x

* play-scala-compile-di-example/2.6.x: (66 commits)
  Nest play-scala-compile-di-example
  Updated with template-control on 2019-02-13T20:25:39.413Z (playframework#87)
  Updated with template-control on 2019-02-01T10:40:33.389Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:58.005Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.884Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:42.104Z (playframework#81)
  Updated with template-control on 2019-01-04T17:13:23.804Z (playframework#76)
  Drop oraclejdk10
  Updated with template-control on 2018-11-29T15:50:43.529Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Made minor changes to the README file documentation
  Updated with template-control on 2018-10-08T19:11:41.162Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:49.815Z (playframework#69)
  Updated with template-control on 2018-08-20T20:37:13.694Z (playframework#68)
  Updated with template-control on 2018-07-19T01:58:55.403Z (playframework#66)
  Updated with template-control on 2018-07-16T18:38:45.033Z (playframework#65)
  Upgrade branch 2.6.x using TemplateControl (playframework#64)
  Updated with template-control on 2018-05-27T23:54:09.150Z (playframework#63)
  Updated with template-control on 2018-04-06T19:34:58.408Z (playframework#61)
  Updated with template-control on 2018-03-02T18:56:27.945Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-isolated-slick-example/2.6.x…
5905ae3 
…' into 2.6.x

* play-scala-isolated-slick-example/2.6.x: (53 commits)
  Nest play-scala-isolated-slick-example
  Updated with template-control on 2019-02-13T20:25:39.661Z (playframework#84)
  Updated with template-control on 2019-02-01T10:40:33.042Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:58.033Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:45.882Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-08T14:44:41.929Z (playframework#78)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Remove JDK 9 & 10
  Updated with template-control on 2018-11-29T15:50:43.213Z   /.mergify.yml:     wrote /.mergify.yml   **build.sbt:     scalaVersion := "2.12.7"
  Updated with template-control on 2018-10-08T19:11:41.295Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")
  Updated with template-control on 2018-09-11T20:14:50.342Z (playframework#68)
  Updated with template-control on 2018-08-20T19:30:29.032Z (playframework#67)
  Updated with template-control on 2018-07-19T01:58:56.035Z (playframework#65)
  Updated with template-control on 2018-07-16T18:38:45.677Z (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#63)
  Updated with template-control on 2018-05-27T23:54:09.691Z (playframework#62)
  Updated with template-control on 2018-04-06T19:34:57.999Z (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#58)
  Fix cross build to sbt 1.1.0 (playframework#55)
  Update Play to version 2.6.10 (playframework#52)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-macwire-di-example/2.6.x' in…
47be391 
…to 2.6.x

* play-scala-macwire-di-example/2.6.x: (65 commits)
  Nest play-scala-macwire-di-example
  Updated with template-control on 2019-02-13T20:25:39.672Z (playframework#82)
  Updated with template-control on 2019-02-01T10:40:33.270Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.898Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:46.033Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml   **build.gradle:         playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2"
  Updated with template-control on 2019-01-08T14:44:44.697Z (playframework#76)
  Updated with template-control on 2019-01-04T17:13:23.938Z (playframework#71)
  Upgrade branch 2.6.x using TemplateControl (playframework#70)
  Updated with template-control on 2018-10-08T19:11:40.533Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.619Z (playframework#66)
  Updated with template-control on 2018-08-20T20:37:13.853Z (playframework#65)
  Updated with template-control on 2018-07-19T01:58:55.845Z (playframework#63)
  Updated with template-control on 2018-07-16T18:38:45.430Z (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Updated with template-control on 2018-05-27T23:54:10.362Z (playframework#60)
  Updated with template-control on 2018-04-06T19:34:59.235Z (playframework#58)
  Updated with template-control on 2018-03-02T18:56:30.403Z (playframework#57)
  Upgrade branch 2.6.x using TemplateControl (playframework#56)
  Fix cross build to sbt 1.1.0 (playframework#55)
  Upgrade branch 2.6.x using TemplateControl (playframework#54)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-secure-session-example/2.6.x…
fff317a 
…' into 2.6.x

* play-scala-secure-session-example/2.6.x: (70 commits)
  Nest play-scala-secure-session-example
  Updated with template-control on 2019-02-13T20:17:46.435Z (playframework#95)
  Updated with template-control on 2019-02-01T10:40:32.758Z (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#92)
  Upgrade branch 2.6.x using TemplateControl (playframework#91)
  Upgrade branch 2.6.x using TemplateControl (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#82)
  Upgrade branch 2.6.x using TemplateControl (playframework#81)
  adds mergify file (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#77)
  Updated with template-control on 2018-08-20T20:37:13.861Z (playframework#71)
  Updated with template-control on 2018-07-19T01:58:55.998Z (playframework#69)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#68)
  Upgrade branch 2.6.x using TemplateControl (playframework#66)
  Updated with template-control on 2018-05-27T23:54:09.617Z (playframework#65)
  Updated with template-control on 2018-04-06T19:34:58.475Z (playframework#63)
  Updated with template-control on 2018-03-02T18:56:28.210Z (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Fix cross build to sbt 1.1.0 (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-slick-example/2.6.x' into 2.6.x
0a2f46a 
* play-scala-slick-example/2.6.x: (55 commits)
  Nest play-scala-slick-example
  Updated with template-control on 2019-02-13T20:25:39.652Z (playframework#92)
  Upgrade branch 2.6.x using TemplateControl (playframework#90)
  Updated with template-control on 2019-01-17T15:10:58.253Z (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#88)
  Updated with template-control on 2019-01-08T14:44:41.666Z (playframework#85)
  Updated with template-control on 2019-01-04T17:13:23.925Z (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#78)
  Upgrade branch 2.6.x using TemplateControl (playframework#75)
  Updated with template-control on 2018-09-11T20:14:50.417Z (playframework#74)
  Updated with template-control on 2018-08-20T20:37:13.878Z (playframework#73)
  Updated with template-control on 2018-07-19T01:58:55.997Z (playframework#71)
  Updated with template-control on 2018-07-16T18:38:45.495Z (playframework#70)
  Upgrade branch 2.6.x using TemplateControl (playframework#68)
  Updated with template-control on 2018-05-27T23:54:09.171Z (playframework#67)
  Updated with template-control on 2018-04-06T19:34:57.974Z (playframework#65)
  Updated with template-control on 2018-03-02T18:56:28.233Z (playframework#64)
  Upgrade branch 2.6.x using TemplateControl (playframework#63)
  Fix cross build to sbt 1.1.0 (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  ...
octonato pushed a commit to octonato/play-samples that referenced this pull request Dec 4, 2019
@dwijnand
Merge remote-tracking branch 'play-scala-streaming-example/2.6.x' int…
bbc60d4 
…o 2.6.x

* play-scala-streaming-example/2.6.x: (52 commits)
  Nest play-scala-streaming-example
  Updated with template-control on 2019-02-13T20:25:39.555Z (playframework#77)
  Upgrade branch 2.6.x using TemplateControl (playframework#75)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Upgrade branch 2.6.x using TemplateControl (playframework#73)
  Updated with template-control on 2019-01-08T14:44:41.633Z (playframework#71)
  Updated with template-control on 2019-01-04T17:13:23.822Z (playframework#67)
  Upgrade branch 2.6.x using TemplateControl (playframework#66)
  Upgrade branch 2.6.x using TemplateControl (playframework#63)
  Updated with template-control on 2018-09-11T20:14:50.169Z (playframework#62)
  Updated with template-control on 2018-08-20T20:37:13.651Z (playframework#60)
  Updated with template-control on 2018-07-16T18:38:45.481Z (playframework#59)
  Upgrade branch 2.6.x using TemplateControl (playframework#58)
  Updated with template-control on 2018-05-27T23:54:09.895Z (playframework#57)
  Updated with template-control on 2018-04-06T19:34:57.566Z (playframework#56)
  current -> latest (playframework#55)
  Updated with template-control on 2018-03-02T18:56:28.085Z (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#53)
  Fix cross build to sbt 1.1.0 (playframework#52)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasi35 ignasi35 ignasi35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwijnand @ignasi35