Replace the deprecated JKS with PKCS12 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Dec 20, 2019
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
…ork#78) **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.21")
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
…2.6.x Upgrade branch 2.6.x using TemplateControl
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
…2.6.x Upgrade branch 2.6.x using TemplateControl
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
```
Updated with template-control on 2019-01-17T15:10:57.627Z
/.mergify.yml:
wrote /.mergify.yml
```
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
…ork#78) /.mergify.yml: wrote /.mergify.yml
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
….6.x * play-java-starter-example/2.6.x: (57 commits) Nest play-java-starter-example Updated with template-control on 2019-02-13T20:25:39.664Z (playframework#103) Upgrade branch 2.6.x using TemplateControl (playframework#99) Upgrade branch 2.6.x using TemplateControl (playframework#98) Upgrade branch 2.6.x using TemplateControl (playframework#97) Updated with template-control on 2019-01-08T14:44:42.254Z (playframework#95) Updated with template-control on 2019-01-04T17:13:24.036Z (playframework#90) Upgrade branch 2.6.x using TemplateControl (playframework#89) Improve README (playframework#81) Upgrade branch 2.6.x using TemplateControl (playframework#79) Updated with template-control on 2018-09-11T20:14:50.628Z (playframework#78) Updated with template-control on 2018-08-20T20:37:14.072Z (playframework#77) Updated with template-control on 2018-07-19T01:58:56.147Z (playframework#74) Updated with template-control on 2018-07-16T18:38:45.658Z (playframework#73) Upgrade branch 2.6.x using TemplateControl (playframework#71) Updated with template-control on 2018-05-27T23:54:09.356Z (playframework#69) Updated with template-control on 2018-04-06T19:34:58.808Z (playframework#66) Change disabled to enabled (playframework#64) Use discuss forum (playframework#62) Enable localhost:9000 as allowed host by default. (playframework#61) ...
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
… 2.6.x * play-java-streaming-example/2.6.x: (45 commits) Nest play-java-streaming-example Updated with template-control on 2019-02-13T20:25:39.687Z (playframework#81) Upgrade branch 2.6.x using TemplateControl (playframework#79) Upgrade branch 2.6.x using TemplateControl (playframework#78) Upgrade branch 2.6.x using TemplateControl (playframework#77) Updated with template-control on 2019-01-08T14:44:41.668Z (playframework#75) Updated with template-control on 2019-01-04T17:13:23.629Z (playframework#70) Upgrade branch 2.6.x using TemplateControl (playframework#69) Upgrade branch 2.6.x using TemplateControl (playframework#66) Updated with template-control on 2018-09-11T20:14:50.512Z (playframework#65) Updated with template-control on 2018-08-20T20:37:13.644Z (playframework#64) Updated with template-control on 2018-07-19T01:58:55.832Z (playframework#62) Updated with template-control on 2018-07-16T18:38:45.449Z (playframework#61) Upgrade branch 2.6.x using TemplateControl (playframework#60) Updated with template-control on 2018-05-27T23:54:09.459Z (playframework#59) Updated with template-control on 2018-04-06T19:34:58.233Z (playframework#57) Updated with template-control on 2018-03-02T18:56:28.174Z (playframework#56) Upgrade branch 2.6.x using TemplateControl (playframework#55) Fix cross build to sbt 1.1.0 (playframework#54) Upgrade branch 2.6.x using TemplateControl (playframework#53) ...
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
… 2.6.x * play-java-websocket-example/2.6.x: (83 commits) Nest play-java-websocket-example Updated with template-control on 2019-02-13T20:25:39.721Z (playframework#100) Upgrade branch 2.6.x using TemplateControl (playframework#96) Upgrade branch 2.6.x using TemplateControl (playframework#94) Upgrade branch 2.6.x using TemplateControl (playframework#93) Updated with template-control on 2019-01-08T14:44:42.192Z (playframework#90) Updated with template-control on 2019-01-04T17:13:23.935Z (playframework#85) Upgrade branch 2.6.x using TemplateControl (playframework#84) Upgrade branch 2.6.x using TemplateControl (playframework#81) Updated with template-control on 2018-09-11T20:14:50.523Z (playframework#79) Updated with template-control on 2018-08-20T20:37:13.896Z (playframework#78) Updated with template-control on 2018-07-19T01:58:55.842Z (playframework#76) Updated with template-control on 2018-07-16T18:38:45.656Z (playframework#75) Upgrade branch 2.6.x using TemplateControl (playframework#74) Updated with template-control on 2018-05-27T23:54:09.712Z (playframework#73) Updated with template-control on 2018-04-06T19:34:58.514Z (playframework#71) Updated with template-control on 2018-03-02T18:56:28.527Z (playframework#70) Upgrade branch 2.6.x using TemplateControl (playframework#69) Fix cross build to sbt 1.1.0 (playframework#68) Upgrade branch 2.6.x using TemplateControl (playframework#67) ...
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
…to 2.6.x * play-scala-fileupload-example/2.6.x: (50 commits) Nest play-scala-fileupload-example Updated with template-control on 2019-02-13T20:25:39.491Z (playframework#78) Updated with template-control on 2019-02-01T10:40:33.510Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-17T15:10:57.985Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.799Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml **build.gradle: playTest "org.scalatestplus.play:scalatestplus-play_$scalaVersion:3.1.2" Updated with template-control on 2019-01-08T14:44:41.664Z (playframework#72) Updated with template-control on 2019-01-04T17:13:23.928Z (playframework#67) Upgrade branch 2.6.x using TemplateControl (playframework#66) Updated with template-control on 2018-10-08T19:11:40.600Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") **build.gradle: def playVersion = "2.6.20" Update application.conf (playframework#62) Updated with template-control on 2018-09-11T20:14:49.954Z (playframework#61) Updated with template-control on 2018-08-20T20:37:13.724Z (playframework#60) Updated with template-control on 2018-07-19T01:58:55.837Z (playframework#58) Updated with template-control on 2018-07-16T18:38:45.429Z (playframework#57) Upgrade branch 2.6.x using TemplateControl (playframework#56) Updated with template-control on 2018-05-27T23:54:09.258Z (playframework#55) Updated with template-control on 2018-04-06T19:34:57.720Z (playframework#53) Update application.conf Update application.conf Add explicit file upload limit ...
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
…' into 2.6.x * play-scala-isolated-slick-example/2.6.x: (53 commits) Nest play-scala-isolated-slick-example Updated with template-control on 2019-02-13T20:25:39.661Z (playframework#84) Updated with template-control on 2019-02-01T10:40:33.042Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-17T15:10:58.033Z /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-16T12:08:45.882Z /LICENSE: wrote /LICENSE /NOTICE: wrote /NOTICE /.mergify.yml: wrote /.mergify.yml Updated with template-control on 2019-01-08T14:44:41.929Z (playframework#78) Upgrade branch 2.6.x using TemplateControl (playframework#73) Remove JDK 9 & 10 Updated with template-control on 2018-11-29T15:50:43.213Z /.mergify.yml: wrote /.mergify.yml **build.sbt: scalaVersion := "2.12.7" Updated with template-control on 2018-10-08T19:11:41.295Z **/plugins.sbt: addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20") Updated with template-control on 2018-09-11T20:14:50.342Z (playframework#68) Updated with template-control on 2018-08-20T19:30:29.032Z (playframework#67) Updated with template-control on 2018-07-19T01:58:56.035Z (playframework#65) Updated with template-control on 2018-07-16T18:38:45.677Z (playframework#64) Upgrade branch 2.6.x using TemplateControl (playframework#63) Updated with template-control on 2018-05-27T23:54:09.691Z (playframework#62) Updated with template-control on 2018-04-06T19:34:57.999Z (playframework#60) Upgrade branch 2.6.x using TemplateControl (playframework#58) Fix cross build to sbt 1.1.0 (playframework#55) Update Play to version 2.6.10 (playframework#52) ...
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
* play-scala-slick-example/2.6.x: (55 commits) Nest play-scala-slick-example Updated with template-control on 2019-02-13T20:25:39.652Z (playframework#92) Upgrade branch 2.6.x using TemplateControl (playframework#90) Updated with template-control on 2019-01-17T15:10:58.253Z (playframework#89) Upgrade branch 2.6.x using TemplateControl (playframework#88) Updated with template-control on 2019-01-08T14:44:41.666Z (playframework#85) Updated with template-control on 2019-01-04T17:13:23.925Z (playframework#79) Upgrade branch 2.6.x using TemplateControl (playframework#78) Upgrade branch 2.6.x using TemplateControl (playframework#75) Updated with template-control on 2018-09-11T20:14:50.417Z (playframework#74) Updated with template-control on 2018-08-20T20:37:13.878Z (playframework#73) Updated with template-control on 2018-07-19T01:58:55.997Z (playframework#71) Updated with template-control on 2018-07-16T18:38:45.495Z (playframework#70) Upgrade branch 2.6.x using TemplateControl (playframework#68) Updated with template-control on 2018-05-27T23:54:09.171Z (playframework#67) Updated with template-control on 2018-04-06T19:34:57.974Z (playframework#65) Updated with template-control on 2018-03-02T18:56:28.233Z (playframework#64) Upgrade branch 2.6.x using TemplateControl (playframework#63) Fix cross build to sbt 1.1.0 (playframework#62) Upgrade branch 2.6.x using TemplateControl (playframework#61) ...
ignasi35
pushed a commit
to ignasi35/play-samples
that referenced
this pull request
May 20, 2020
* play-scala-tls-example/2.6.x: (53 commits) Nest play-scala-tls-example Updated with template-control on 2019-02-13T20:25:39.799Z (playframework#100) Upgrade branch 2.6.x using TemplateControl (playframework#98) Upgrade branch 2.6.x using TemplateControl (playframework#97) Upgrade branch 2.6.x using TemplateControl (playframework#96) Updated with template-control on 2019-01-08T14:44:41.961Z (playframework#93) Updated with template-control on 2019-01-04T21:47:52.378Z (playframework#87) Make Travis CI fast_finish Upgrade branch 2.6.x using TemplateControl (playframework#83) remove array syntax on label conditional check mergify with squash (playframework#79) minor mergify improvements (playframework#78) mergify file (playframework#77) AkkaHttpServer.Context - removed usage of deprecated API (playframework#76) Upgrade branch 2.6.x using TemplateControl (playframework#71) Upgrade branch 2.6.x using TemplateControl (playframework#55) Fix cross build to sbt 1.1.0 (playframework#54) Upgrade branch 2.6.x using TemplateControl (playframework#53) Upgrade branch 2.6.x using TemplateControl (playframework#51) Updated with template-control on 2017-12-21T20:59:17.421Z (playframework#50) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JKS keystores are deprecated and
keytoolhas been issuing a warning about that for a while.This PR moves all samples code (specially
play-scala-tls-example) away from JKS in favor of PKCS.The most important details is that PKCS12 doesn't have a default password (in JKS it was
changeit).