Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cache return Future[T] #133

Closed
wsargent opened this issue Jun 13, 2017 · 0 comments · Fixed by #143
Closed

Make Cache return Future[T] #133

wsargent opened this issue Jun 13, 2017 · 0 comments · Fixed by #143

Comments

@wsargent
Copy link
Member

The cache interface is synchronous:

package play.api.libs.ws.ahc.cache

trait Cache {
  def get(key: EffectiveURIKey): ResponseEntry
  def put(key: EffectiveURIKey, entry: ResponseEntry): Unit
  def remove(key: EffectiveURIKey): Unit
  def close(): Unit
}

Should be made to return Future[ResponseEntry] so that IO blocking / disk based cache system will work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant