Fix build cache issues #10014
Merged
Fix build cache issues #10014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to cache ivy local artifacts generated for the build, but it is okay to keep Play artifacts in ivy cache directory since they are used when checking binary compatibility.
mkurz
reviewed
Jan 28, 2020
dwijnand
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
This is relevant because MiMa (still) uses Ivy and therefore ~/.ivy2/cache, good catch.
This rm existed for scripted and before using sbt-dynver, to safeguard from publishLocal'ing and then running scripted on an older version (not confirmed, but feared). So it can go now.
|
I am pretty sure we can backport to 2.8.x because also in 2.8.x we now use sbt-dynver. |
|
@Mergifyio backport 2.8.x |
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Jan 22, 2021
Fix build cache issues (bp #10014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.