Convert .travis-jvmopts to .sbtopts #10062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without those, on my machine (both jdk8 and jdk11), 'sbt clean +publishLocal' would run out of memory throwing confusing errors such as 'java.lang.NoClassDefFoundError: xsbt/DelegatingReporter$PositionImpl$'. Apparently the JVM heuristics for selecting these values aren't very good yet, and it would be helpful to supply some reasonable defaults as .sbtopts so new contributors don't have to deal with this.
marcospereira
approved these changes
Feb 14, 2020
|
For some reason I also see |
|
@Mergifyio backport 2.8.x |
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Apr 10, 2020
Convert .travis-jvmopts to .sbtopts (bp #10062)
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Apr 28, 2021
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Apr 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without those, on my machine (both jdk8 and jdk11),
'sbt clean +publishLocal' would run out of memory throwing confusing errors
such as 'java.lang.NoClassDefFoundError: xsbt/DelegatingReporter$PositionImpl$'.
Apparently the JVM heuristics for selecting these values aren't very good yet,
and it would be helpful to supply some reasonable defaults as .sbtopts so new
contributors don't have to deal with this.