import CollectionConverters or JavaConverters based on scala version #10154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Mar 31, 2020
| @@ -29,18 +29,23 @@ import com.typesafe.sbt.web.SbtWeb.autoImport._ | |||
| import com.typesafe.sbt.web.SbtWeb.autoImport.WebKeys._ | |||
|
|
|||
| object PlaySettings { | |||
|
|
|||
| lazy val converterImport = | |||
| if (PlayVersion.scalaVersion >= "2.13.0") "scala.jdk.CollectionConverters._" | |||
There was a problem hiding this comment.
PlayVersion.scalaVersion is a String, so comparing that to 2.13.0 with >= probably doesn't do what we want.
There was a problem hiding this comment.
do you mean scala string comparison? I checked the doc https://www.scala-lang.org/api/2.12.1/scala/collection/immutable/StringOps.html#>=(that:A):Boolean here, or is it the logic issue? Thanks!
There was a problem hiding this comment.
Yes: "2.12.2" >= "2.12.1" is true, but also "2.12.2" >= "2.12.10", so using string comparison to compare versions is dangerous (even if it might happen to work in some situations).
|
Great work. Thanks @fusuiyi123 |
|
@Mergifyio backport 2.8.x |
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Apr 15, 2020
import CollectionConverters or JavaConverters based on scala version (bp #10154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #9845
Purpose
What does this PR do?
if scala version >=
2.13.0importscala.jdk.CollectionConverters._else import
scala.collection.JavaConverters._Background Context
Why did you take this approach?
References
Are there any relevant issues / PRs / mailing lists discussions?