Overload HttpExecution.fromThread with ExecutionContextExecutor param #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmethvin Can you give me thumps up on this one as well? Would be the last one for now. |
|
@Mergifyio backport 2.8.x |
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Apr 9, 2020
Overload HttpExecution.fromThread with ExecutionContextExecutor param (bp #10162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No casting needed anymore (see the docs I updated).
Also the Scala API has to overload (which will be called now), only the Java API is missing it:
playframework/core/play/src/main/scala/play/core/j/HttpExecutionContext.scala
Line 30 in eede966