Add type annotation for Optional.empty #10442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With sbt 1.4.x, the type is inferred as Optional[Nothing] rather than Optional[ClassFileManager].
|
I'm wondering if there was a regression in scala that caused the type inference to fail. |
|
I guess this fixes #10431 |
|
It also needs sbt/zinc#909 to be fully fixed. |
mkurz
approved these changes
Sep 7, 2020
|
@Mergifyio backport 2.8.x |
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Feb 8, 2021
Add type annotation for Optional.empty (bp #10442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sbt 1.4.x, the type is inferred as Optional[Nothing] rather than
Optional[ClassFileManager].
Pull Request Checklist
Helpful things
Fixes
Fixes #xxxx
Purpose
What does this PR do?
Background Context
Why did you take this approach?
References
Are there any relevant issues / PRs / mailing lists discussions?