Catch Throwable instead of NonFatal when starting prod server #10690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport 2.8.x |
|
Command
|
|
Looks good to me, thanks! |
gmethvin
approved these changes
Feb 15, 2021
| @@ -82,14 +81,14 @@ object ProdServerStart { | |||
|
|
|||
| server | |||
| } catch { | |||
| case NonFatal(e) => | |||
| case e: Throwable => | |||
There was a problem hiding this comment.
I think this change is fine, but I'm wondering if this catch block should look like:
case e: Throwable =>
try {
pidFile.foreach(_.delete())
} finally {
throw e // ignore any exception thrown by `delete`
}
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Feb 15, 2021
Catch Throwable instead of NonFatal when starting prod server (bp #10690)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10681