fix Int overflow in BodyParsers.anyContent(maxLength: Option[Long]) #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwei-k
commented
Mar 5, 2021
Comment on lines
+921
to
922
| def maxLengthOrDefault = maxLength.getOrElse(DefaultMaxTextLength) | ||
| def maxLengthOrDefaultLarge = maxLength.getOrElse(DefaultMaxDiskLength) |
There was a problem hiding this comment.
I don't know the reason there are maxLengthOrDefault and maxLengthOrDefaultLarge both. 🤔
Should we remove either one?
There was a problem hiding this comment.
It looks like maxLengthOrDefault is the maximum for a body stored in memory, whereas maxLengthOrDefaultLarge is the maximum for a body stored on disk. Perhaps they could be renamed to:
def maxMemoryLength = maxLength.getOrElse(DefaultMaxTextLength)
def maxDiskLength = maxLength.getOrElse(DefaultMaxDiskLength)
mkurz
approved these changes
Mar 10, 2021
|
@Mergifyio backport 2.8.x |
|
Command
|
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Mar 10, 2021
fix Int overflow in BodyParsers.anyContent(maxLength: Option[Long]) (bp #10741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
fix Int overflow. please see test case
Purpose
Background Context
References
use
Longsince #8627