Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer -agentlib:jdwp= over -Xrunjdwp: #10885

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jun 2, 2021

Using -Xrunjdwp: is outdated, better is to use -agentlib:jdwp= starting with Java 5: https://stackoverflow.com/questions/138511

Also see what sbt uses when running sbt -jvm-debug 9999:

if defined JVM_DEBUG_PORT (
  set _JAVA_OPTS=!_JAVA_OPTS! -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=!JVM_DEBUG_PORT!
)

@mkurz
Copy link
Member Author

mkurz commented Jun 2, 2021

@Mergifyio backport 2.8.x

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2021

Command backport 2.8.x: pending

Waiting for the pull request to get merged

@mergify mergify bot merged commit e8fffd0 into playframework:master Jun 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2021

Command backport 2.8.x: success

Backports have been created

@mkurz mkurz deleted the debug_fix branch June 16, 2021 07:03
mergify bot added a commit that referenced this pull request Jun 16, 2021
Prefer -agentlib:jdwp= over -Xrunjdwp: (backport #10885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants