Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable substitution in evolution warning #10931

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jul 20, 2021

Just ran into that, currently the warning looks like:

[warn] p.a.d.e.DefaultEvolutionsApi - could not create ${schema}${evolutions_table} table

We need to wrap the string in applySchemaAndTable(...).

@mkurz
Copy link
Member Author

mkurz commented Jul 20, 2021

@Mergifyio backport 2.8.x

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2021

Command backport 2.8.x: pending

Waiting for the pull request to get merged

@@ -429,6 +429,9 @@ class DatabaseEvolutions(
checkEvolutionsState()
}

// SQL helpers
import EvolutionsHelper._
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to move up to access the applySchemaAndTable() method

@mergify mergify bot merged commit 71707c5 into playframework:master Aug 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Command backport 2.8.x: success

Backports have been created

@mkurz mkurz deleted the fix_evo_msg branch August 26, 2021 07:22
mergify bot added a commit that referenced this pull request Aug 27, 2021
Fix variable substitution in evolution warning (backport #10931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants