Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play-test to PlayImport #10940

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Add play-test to PlayImport #10940

merged 1 commit into from
Aug 26, 2021

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jul 29, 2021

I am working on a test library in Play which depends on play-test. It would be nice to just add test to the library dependencies.

  • playframework/build.sbt

    Lines 179 to 190 in 44886b0

    lazy val PlayTestProject = PlayCrossBuiltProject("Play-Test", "testkit/play-test")
    .settings(
    libraryDependencies ++= testDependencies ++ Seq(h2database % "test"),
    (Test / parallelExecution) := false
    )
    .dependsOn(
    PlayGuiceProject,
    PlayServerProject,
    // We still need a server provider when running Play-Test tests.
    // Since Akka HTTP is the default, we should use it here.
    PlayAkkaHttpServerProject % "test"
    )
  • https://repo1.maven.org/maven2/com/typesafe/play/play-test_2.13/

@mkurz
Copy link
Member Author

mkurz commented Jul 29, 2021

@Mergifyio backport 2.8.x

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2021

Command backport 2.8.x: pending

Waiting for the pull request to get merged

@mkurz
Copy link
Member Author

mkurz commented Jul 29, 2021

/home/travis/build/playframework/playframework/documentation/build.sbt:34: error: reference to test is ambiguous;

I will rename it to playTest. Renamed.

@octonato octonato merged commit 75b1b55 into master Aug 26, 2021
@octonato octonato deleted the PlayImport_play-test branch August 26, 2021 07:12
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Command backport 2.8.x: success

Backports have been created

mergify bot added a commit that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants