Clean up eliminate warnings tackle deprecations #11001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PromanSEW
reviewed
Oct 21, 2021
core/play-guice/src/main/scala/play/api/inject/guice/GuiceInjectorBuilder.scala
Outdated
Show resolved
Hide resolved
gmethvin
approved these changes
Oct 23, 2021
BillyAutrey
reviewed
Oct 26, 2021
| @@ -17,7 +17,8 @@ static Binder binder(Object module) { | |||
| if (module instanceof AbstractModule) { | |||
| try { | |||
| Method method = AbstractModule.class.getDeclaredMethod("binder"); | |||
| if (!method.isAccessible()) { | |||
| if (!method.isAccessible()) { // Fixme: remove this deprecated method. Use | |||
There was a problem hiding this comment.
Is there a hook to create issues on //TODO///Fixme comments? If not, we might consider adding it (or just opening issues for these notations)
There was a problem hiding this comment.
Maybe there is a GitHub action for that?
|
Closed PR and re-open to trigger Travis build |
eloots
force-pushed
the
clean-up-eliminate-warnings-tackle-deprecations
branch
from
feeaccd
to
cc74fd5
Compare
|
Hey @eloots can you rebase once more, I finally want to go through all that pull requests tomorrow. Thanks! |
mkurz
force-pushed
the
clean-up-eliminate-warnings-tackle-deprecations
branch
from
cc74fd5
to
0571d82
Compare
- Switch scala.collection.JavaConverters to scala.jdk.CollectionConverters - Remove unnecessary func(scala.Function1)
- Switch: scala.collection.JavaConverters to scala.jdk.CollectionConverters scala.compat.java8.OptionConverters to scala.jdk.OptionConverters - Switch `toIterator` to `iterator` - `mapValues` should be applied on a `view`
- Switch deprecated Scala `Stream` to `LazyList` - `mapValues` should be applied on a `view` - As `Either` is now right biased, apply changes accordingly - Use `compare.sign` instead if `compare.signum` - Replace concatenation using `+` of Strings (incl. implicit conversions to strings) with string interpolation - Remove `Traversable`. Replace with `Iterable` - Replace 'symbol syntax with explicit calls to `Symbol` - Switch: scala.collection.JavaConverters to scala.jdk.CollectionConverters scala.compat.java8.OptionConverters to scala.jdk.OptionConverters - Fix utilisation of deprecated auto-application to `()` - Switch `toIterator` to `iterator`
- Switch: scala.collection.JavaConverters to scala.jdk.CollectionConverters scala.compat.java8.OptionConverters to scala.jdk.OptionConverters - Fix utilisation of deprecated auto-application to `()`
mkurz
force-pushed
the
clean-up-eliminate-warnings-tackle-deprecations
branch
from
0571d82
to
69ba653
Compare
mkurz
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #xxxx
Purpose
Compiling the codebase with Scala 2.13.5 generates a ton of warnings. This PR eliminates a lot of them (but not all).
Background Context
Maintaining a project with that many warnings isn't right.
References