[2.8.x] Reverts #11109 (downgrade ssl-config back to 0.4.x) #11202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11109, kind of the same like I just did with play-ws: playframework/play-ws#662
akka did not upgrade to ssl-config 0.6.x because it has binary compatibility issues with 0.4.x. Actually it got upgraded first, see akka/akka#31046, then it got partially reverted, see akka/akka#31252.
Partially reverted means that only the dependency was downgraded again, however akka itself removed methods and classes not available anymore in ssl-config 0.6.x, so akka 2.6.19 itself works nicely with ssl-config 0.6.x. However they didn't want to upgrade to latest ssl-config to not break libraries depending on akka and which also use removed methods and/or classes from ssl-config 0.4.3.
For Play stable branch 2.8.x that means we don't need to upgrade to ssl-config 0.6.0 (and therefore also not play-ws snapshot).