New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Evolutions.scala #11345
Update Evolutions.scala #11345
Conversation
HSQL does not support the data type "text". Therefore it needs an additional statement, to create the initial play_evolutions table. Steps: 1. Create an additional pattern 'HsqlJdbcUrl' für HSQL in Evolutions.scala 2. Provide a custom SQL script for 'play_evolutions' table creation in EvolutionsApi.scala Affected files: play.api.db.evolutions.Evolutions.scala play.api.db.evolutions.EvolutionsApi.scala
Hi @BlankFX, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
@BlankFX thanks! However it seems your pull request still is incomplete. Are you planning to work on it? |
This commit is linked to Pull-Request Update Evolutions.scala playframework#11345.
I added the remaining code lines in "EvolutionsApi.scala". |
@BlankFX You need to run |
@BlankFX hmm.. there is still a formatting issue. Can you check again? |
@mkurz Na endlich! Finally it worked. THX :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BlankFX, I will backport this for the next 2.8.x release as well.
@Mergifyio backport 2.8.x |
✅ Backports have been created
|
HSQL does not support the data type "text". Therefore it needs an additional statement, to create the initial play_evolutions table.
Steps:
Affected files:
play.api.db.evolutions.Evolutions.scala
play.api.db.evolutions.EvolutionsApi.scala
Pull Request Checklist
Helpful things
Fixes
Scala Play Evolutions "play_evolutions" table creation.
Purpose
I allows the use of Play Evolutions with a HSQL Database for Scala Play.
Background Context
I used Play Evolutions with HSQL local database server
References
Are there any relevant issues / PRs / mailing lists discussions?