Fix transforming of PathBindable and also the anyValPathBindable macro #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport 2.8.x |
✅ Backports have been created
|
mkurz
commented
Mar 15, 2023
|
|
||
| override def unbind(key: String, value: ${t.tpe}): String = { | ||
| binder.unbind(key, value.${param.name.toTermName}) | ||
| } |
There was a problem hiding this comment.
The javascriptUnbind does not get overridden.
mkurz
commented
Mar 15, 2023
|
|
||
| } | ||
| private val binder = _root_.scala.Predef.implicitly[_root_.play.api.mvc.PathBindable[${param.typeSignature}]] | ||
| binder.transform((p: ${param.typeSignature}) => new ${t.tpe}(p), (p: ${t.tpe}) => p.${param.name.toTermName}) |
There was a problem hiding this comment.
Using transform is preferred, safer and saner. Just like we do below (line 29) for anyValQueryStringBindable.
mkurz
commented
Mar 15, 2023
| } | ||
| "JavaScript Unbind Pferd as String which is a Boolean and uses special js unbind" in { | ||
| implicitly[PathBindable[Pferd]].javascriptUnbind must equalTo("function(k,v){return !!v}") | ||
| } |
There was a problem hiding this comment.
This test would fail without both fixes applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the macro stuff for Scala 3 I noticed two bugs:
AnyValregarding Pathbindable also does not correctly transform an AnyVal. Even when the above is fixed, the macro does create a new instance which does not override the js method... calling transform is the preferred way here.The added tests test both scenarios.