fix reverse routes escape with fixed param

[xuwei-k]

Pull Request Checklist

• Have you read How to write the perfect pull request?
• Have you read through the contributor guidelines?
• Have you referenced any issues you're fixing using commit message keywords?
• Have you added copyright headers to new files?
• Have you checked that both Scala and Java APIs are updated?
• Have you updated the documentation for both Scala and Java sections?
• Have you added tests for any changed functionality?

Helpful things

Fixes

Fix reverse routes generated code.

Purpose

escape if Scala keyword

Background Context

play generate following code and scalac report compile error before this fix

[error] target/scala-2.13/routes/main/controllers/ReverseRoutes.scala:382:35: illegal start of simple expression
[error]         case (_pf_escape_type) if type == "x" =>
[error]                                   ^
[error] target/scala-2.13/routes/main/controllers/ReverseRoutes.scala:383:97: '=>' expected but ';' found.
[error]           implicit lazy val _rrc = new play.core.routing.ReverseRouteContext(Map(("type", "x"))); _rrc
[error]                                                                                                 ^
[error] two errors found

References

[mkurz]

Nice catch. I checked the generated code:

        case (_pf_escape_type) if type == "x" =>

now (correctly) becomes:

        case (_pf_escape_type) if _pf_escape_type == "x" =>

This is a bug fix and should be backported to 2.8.x

[mkurz]

@Mergifyio backport 2.8.x

[mergify]

backport 2.8.x

✅ Backports have been created

• #11779 [2.8.x] fix reverse routes escape with fixed param (backport #11774) by @xuwei-k has been created for branch 2.8.x

[mkurz]

@xuwei-k This is part of Play 2.8.20 (but I guess you know that 😉)