Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8.x] Support setting of hikari keepaliveTime (backport #11805) by @gheine #11809

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 12, 2023

This is an automatic backport of pull request #11805 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mkurz
Copy link
Member

mkurz commented May 12, 2023

We can't backport because 2.8.x uses an older version of HikariCP which does not provide yet provide the method necessary:

Error:  /home/runner/work/playframework/playframework/persistence/play-jdbc/src/main/scala/play/api/db/HikariCPModule.scala:122:84: value setKeepaliveTime is not a member of com.zaxxer.hikari.HikariConfig
Error:      config.get[Option[Duration]]("keepaliveTime").foreach(duration => hikariConfig.setKeepaliveTime(toMillis(duration)))
Error:                                                                                     ^
Error:  one error found

We also can't upgrade HikariCP in 2.8.x because newer releases dropped support for Java 8

@mkurz mkurz closed this May 12, 2023
@mkurz mkurz deleted the mergify/bp/2.8.x/pr-11805 branch May 12, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants