Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing newline in SSR #11848

Merged
merged 1 commit into from Jul 11, 2023
Merged

Conversation

ryoppy
Copy link
Contributor

@ryoppy ryoppy commented Jun 22, 2023

Fixes #11834

I passed -1 to split in the formatted of the Event object to keep the trailing newline.

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, we can backport to 2.8.x for its next release.

@mkurz mkurz merged commit ae678b1 into playframework:main Jul 11, 2023
28 checks passed
@mkurz
Copy link
Member

mkurz commented Jul 11, 2023

@Mergifyio backport 2.8.x

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

backport 2.8.x

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jul 11, 2023
[2.8.x] Support trailing newline in SSR (backport #11848) by @ryoppy
@mkurz
Copy link
Member

mkurz commented Jul 21, 2023

This is part of just released Play 2.8.20: https://github.com/playframework/playframework/releases/tag/2.8.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing newlines are ignored in SSE
2 participants