Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirectLocation can get location of Permanent Redirect #12223

Merged
merged 1 commit into from Dec 11, 2023

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented Nov 20, 2023

Previously, if the result was a 308 Permanent Redirect, then redirectLocation(result) would return None.

Pull Request Checklist

Helpful things

Purpose

Add support for using play.api.test.Helpers.redirectLocation to get the location of a "Permanent Redirect" (status code 308).

Background Context

It follows the same pattern as other types of redirects.

@mkurz mkurz added this to the 2.9.1 / 3.0.1 milestone Nov 21, 2023
Previously, if the result was a 308 Permanent Redirect, then `redirectLocation(result)` would return
None.
@mkurz mkurz force-pushed the permanent-redirect-location-test branch from adf1c14 to a73b82d Compare December 7, 2023 11:27
@mkurz
Copy link
Member

mkurz commented Dec 7, 2023

@tmccombs Tests are failing, please check (I also force pushed your branch, so you should pull before), thanks!

@mkurz mkurz modified the milestones: 2.9.1 / 3.0.1, 2.9.2 / 3.0.2 Dec 7, 2023
@tmccombs
Copy link
Contributor Author

tmccombs commented Dec 7, 2023

On the surface those errors seem unrelated to my changes.

@tmccombs
Copy link
Contributor Author

tmccombs commented Dec 8, 2023

yeah, these errors really don't seem related to my change. Could it be a flaky build?

@mkurz mkurz modified the milestones: 2.9.2 / 3.0.2, 2.9.1 / 3.0.1 Dec 11, 2023
@mkurz mkurz merged commit 1d0cfc4 into playframework:main Dec 11, 2023
26 checks passed
@mkurz
Copy link
Member

mkurz commented Dec 11, 2023

@Mergifyio backport 2.9.x

Copy link
Contributor

mergify bot commented Dec 11, 2023

backport 2.9.x

✅ Backports have been created

@tmccombs tmccombs deleted the permanent-redirect-location-test branch December 11, 2023 21:58
mergify bot added a commit that referenced this pull request Dec 12, 2023
[2.9.x] fix: redirectLocation can get location of Permanent Redirect (backport #12223) by @tmccombs
@mkurz mkurz modified the milestones: 2.9.1, 3.0.1 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants