Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9.x] Bugfix: Always set play.server.http.port, even if disabled (backport #12256) by @mkurz #12257

Merged
merged 1 commit into from Dec 6, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2023

This is an automatic backport of pull request #12256 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

When runninng, within sbt:
run disabled -Dhttps.port=9001
then the play.server.http.port config still is set to 9000, but should "disabled"

(cherry picked from commit 5a9d0c6)
@mkurz mkurz changed the title [2.9.x] [2.8.x] Bugfix: Always set play.server.http.port, even if disabled (backport #12256) by @mkurz [2.9.x] Bugfix: Always set play.server.http.port, even if disabled (backport #12256) by @mkurz Dec 6, 2023
@mergify mergify bot merged commit 9cf06f8 into 2.9.x Dec 6, 2023
27 checks passed
@mergify mergify bot deleted the mergify/bp/2.9.x/pr-12256 branch December 6, 2023 10:45
@mkurz mkurz added this to the 2.9.1 / 3.0.1 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant