[#1542] Quote shell variables JAVA and JAVA_HOME to deal with spaces #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, could you please sign our cla ? http://www.typesafe.com/contribute/cla |
|
Signed. |
pk11
pushed a commit
that referenced
this pull request
Jun 4, 2012
[#1542] Quote shell variables JAVA and JAVA_HOME to deal with spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote some shell variables to deal with spaces in the location of JAVA_HOME.
This is probably most likely on OSX using a developer preview of JDK 1.7.
This doesn't deal with other possibilities of spaces in the path (e.g. spaces in the path to the play code).