Remove dependency on org.apache.ws.commons #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch ! Did not see the junit 3 coupling and was not knowing the spring implementation one. |
juretta
pushed a commit
to juretta/Play20
that referenced
this pull request
Aug 14, 2012
…-play project changes as well
rssh
pushed a commit
to rssh/Play20
that referenced
this pull request
Aug 14, 2012
…project changes as well also improve error messages
ghost
assigned 
|
@benmccann this looks good and I tried to merge this but could not (looks like your xml branch is gone now). Can you please send a new pull request? Thanks in advance. |
|
Sure thing. Looks like there were some changes needed to make it easier to merge anyway since those files were moved or updated. Here's the new pull request: #491 |
mudittuli
pushed a commit
to mudittuli/Play20
that referenced
this pull request
Oct 23, 2012
…-play project changes as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the dependencies a bit lighter. org.apache.ws.commons has not been updated in at least a few years and was putting junit 3 on my main classpath (not even in test scope) and causing me some difficulty since junit 4 is also on my classpath and Eclipse was auto-importing a mix of the two.