[doc] Add example of using WS from main #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsargent
force-pushed
the
doc-add-standalone-example
branch
from
c23d7ed
to
35a9b00
Compare
Adds documentation and examples for using WS standalone. Adds notes to use Play's Timeout feature.
wsargent
force-pushed
the
doc-add-standalone-example
branch
from
35a9b00
to
f08d5c1
Compare
gmethvin
requested changes
Sep 26, 2016
|
|
||
| WSClient client = new AhcWSClient(config, materializer); | ||
| client.url("http://www.google.com").get().whenComplete((r, e) -> { | ||
| Optional.of(r).ifPresent(response -> { |
There was a problem hiding this comment.
Shouldn't we use Optional.ofNullable here?
There was a problem hiding this comment.
...wow. It did not occur to me Optional.of was not the same as Option().
| println(response.allHeaders) | ||
| }.andThen { | ||
| case _ => | ||
| wsClient.close() |
There was a problem hiding this comment.
We should probably do this in main. The way it's structured now makes it look like close should happen on every call.
gmethvin
approved these changes
Sep 27, 2016
|
Needs backport to 2.5.x |
gmethvin
pushed a commit
that referenced
this pull request
Oct 8, 2016
* Add WSClient standalone and timeout docs Adds documentation and examples for using WS standalone. Adds notes to use Play's Timeout feature. * Add Optional.ofNullable, clean up andThen
wsargent
added a commit
to wsargent/playframework
that referenced
this pull request
Oct 18, 2016
* Add WSClient standalone and timeout docs Adds documentation and examples for using WS standalone. Adds notes to use Play's Timeout feature. * Add Optional.ofNullable, clean up andThen
wsargent
added a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
* Add WSClient standalone and timeout docs Adds documentation and examples for using WS standalone. Adds notes to use Play's Timeout feature. * Add Optional.ofNullable, clean up andThen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a description of using Play WS from a main method in the simple case, with no bells or whistles.