New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid publishing microbenchmarks and integration tests artifacts #8845
Merged
ignasi35
merged 3 commits into
playframework:master
from
marcospereira:disable-publishing-tests-benchs
Nov 30, 2018
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,23 @@ | ||
/* | ||
* Copyright (C) 2009-2018 Lightbend Inc. <https://www.lightbend.com> | ||
*/ | ||
import sbt.ScriptedPlugin._ | ||
import sbt._ | ||
import Keys.{version, _} | ||
import java.util.regex.Pattern | ||
|
||
import bintray.BintrayPlugin.autoImport._ | ||
import com.typesafe.sbt.SbtScalariform.autoImport._ | ||
import com.typesafe.sbt.pgp.PgpKeys | ||
import com.typesafe.tools.mima.core.{ProblemFilters, _} | ||
import com.typesafe.tools.mima.plugin.MimaKeys._ | ||
import com.typesafe.tools.mima.plugin.MimaPlugin._ | ||
import de.heikoseeberger.sbtheader.AutomateHeaderPlugin | ||
import de.heikoseeberger.sbtheader.HeaderPlugin.autoImport._ | ||
import scalariform.formatter.preferences._ | ||
import com.typesafe.sbt.SbtScalariform.autoImport._ | ||
import bintray.BintrayPlugin.autoImport._ | ||
import interplay._ | ||
import interplay.Omnidoc.autoImport._ | ||
import interplay.PlayBuildBase.autoImport._ | ||
import java.util.regex.Pattern | ||
import interplay._ | ||
import sbt.Keys.{version, _} | ||
import sbt.ScriptedPlugin._ | ||
import sbt.{Resolver, _} | ||
import scalariform.formatter.preferences._ | ||
|
||
import scala.util.control.NonFatal | ||
|
||
|
@@ -838,6 +840,18 @@ object BuildSettings { | |
ScriptedPlugin.scriptedLaunchOpts += s"-Dproject.version=${version.value}" | ||
) ++ playScriptedSettings | ||
|
||
def disablePublishing = Seq[Setting[_]]( | ||
// This setting will work for sbt 1, but not 0.13. For 0.13 it only affects | ||
// `compile` and `update` tasks. | ||
skip in publish := true, | ||
|
||
// For sbt 0.13 this is what we need to avoid publishing. These settings can | ||
// be removed when we move to sbt 1. | ||
PgpKeys.publishSigned := {}, | ||
publish := {}, | ||
publishLocal := {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How paranoid are you? Sometimes you can't take any chances. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not enough apparently. 🤣 |
||
) | ||
|
||
/** | ||
* A project that runs in the SBT runtime | ||
*/ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you know there's a
aggregateProjects
DSL entry in sbt?This could be just
without having to val (lazy val it, at that), and add it there.
See https://github.com/sbt/sbt/blob/v0.13.17/main/src/main/scala/sbt/internals/DslAst.scala (ignore the typo in the scaladoc of
DslAggregate
, it'saggregateProjects
).