Handle multipart form upload with empty file as BadPart #8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
framework/src/play/src/main/scala/play/core/parsers/Multipart.scala
Outdated
Show resolved
Hide resolved
framework/src/play/src/main/scala/play/core/parsers/Multipart.scala
Outdated
Show resolved
Hide resolved
.../play-integration-test/src/test/scala/play/it/http/parsing/MultipartFormDataParserSpec.scala
Outdated
Show resolved
Hide resolved
|
@marcospereira Please have a look again. Now an empty file will not even be created anymore. I added a |
marcospereira
approved these changes
Dec 18, 2018
| @@ -340,11 +340,11 @@ object Multipart { | |||
| def parseHeader(input: ByteString, headerStart: Int, memoryBufferSize: Int): StateResult = { | |||
| input.indexOfSlice(crlfcrlf, headerStart) match { | |||
| case -1 if input.length - headerStart >= maxHeaderSize => | |||
| bufferExceeded("Header length exceeded buffer size of " + memoryBufferSize) | |||
| bufferExceeded("Header length exceeded maximum header size of " + maxHeaderSize) | |||
|
This still needs to be backported to 2.7.x, seems like it was overlooked. |
octonato
pushed a commit
that referenced
this pull request
Jan 10, 2019
* Handle multipart form upload with empty file as BadPart * Fix failing test because empty file isn't available anymore * Better error log * Revert original fix * Handle multipart form upload with empty file as BadPart * More test cases * Correct error message * Migration notes + mention behaviour in upload docs * One more test (file with newline only)
|
Backported to 2.7.x (cc9783d) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8880 was for empty filenames, this is for empty files.