[codesmell] weird shadowing of parameter in readBytes()

[dirkmueller]

I am not 100% sure this is a bug, but it looks weird:

size_t SoftwareSerial::readBytes(uint8_t * buffer, size_t size) {
    if (!m_rxValid) { return -1; }
    if (0 == (size = m_buffer->pop_n(buffer, size))) {
        rxBits();
>>>        size = m_buffer->pop_n(buffer, size);
    }

The size in the highlighted parameter passed in is always 0 because size is overwritten in the if() condition just above with the result of pop_n. that doesn't look correct to me?