Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation of generated constraints and templates #188

Closed
andreidum opened this issue Jul 6, 2021 · 1 comment
Closed

Fix indentation of generated constraints and templates #188

andreidum opened this issue Jul 6, 2021 · 1 comment

Comments

@andreidum
Copy link

Generated constraints and templates should be indented so that they pass linting. Currently, they fail with:

yamllint .
./constraint.yaml
  1:1       warning  missing document start "---"  (document-start)
  8:5       error    wrong indentation: expected 6 but found 4  (indentation)
  9:7       error    wrong indentation: expected 8 but found 6  (indentation)
  12:7      error    wrong indentation: expected 8 but found 6  (indentation)

./template.yaml
  1:1       warning  missing document start "---"  (document-start)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  13:5      error    wrong indentation: expected 6 but found 4  (indentation)
  75:81     error    line too long (110 > 80 characters)  (line-length)
  131:81    error    line too long (139 > 80 characters)  (line-length)
@jalseth
Copy link
Collaborator

jalseth commented Jul 7, 2021

Hi, thank you for the report. The YAML files are valid and are generated from structs using github.com/ghodss/yaml. In this case, we will not be making changes to accomodate an opinionated linter.

@jalseth jalseth closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants