Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subscription to different events through one WebSocket connection #240

Closed
ondrejtomcik opened this issue Apr 14, 2021 · 0 comments · Fixed by #288
Closed

Support subscription to different events through one WebSocket connection #240

ondrejtomcik opened this issue Apr 14, 2021 · 0 comments · Fixed by #288
Assignees
Labels
🔌 feature New feature request
Milestone

Comments

@ondrejtomcik
Copy link
Member

ondrejtomcik commented Apr 14, 2021

Feature Request

What is the purpose of the feature?

The goal is to be able to drive what events are received through one WS connection. In the current implementation, the new WS has to be open per each event type and device we are interested in.

What specific challenge does this feature solve?

In case we need to subscribe to resource content changes of 1000 devices, we need to open 1000 WS connections.

What alternatives did I consider?

The gRPC Gateway streams would work, but not on the UI.

@ondrejtomcik ondrejtomcik changed the title Optimize handling of subscriptions through Websockets Support subscription to different events through one WebSocket connection Aug 4, 2021
@ondrejtomcik ondrejtomcik added the 🔌 feature New feature request label Aug 4, 2021
@ondrejtomcik ondrejtomcik linked a pull request Aug 9, 2021 that will close this issue
@ondrejtomcik ondrejtomcik added this to the 2.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌 feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants