Setting Plivo hangup_url from Channel Var.

[whitebook]

Since we have plivo_answer_url we should also have plivo_hangup_url and even perhaps xfer_url?

I noticed I am not getting post backs on hangup to the right url it is going to the default URL...

[whitebook]

I see xfer is there? I see hangup is set to None.
Had to update my trunk to see changes. (Sorry)

[whitebook]

I updated and I see it was added to the code base.

I still think there is a problem with it;

I had to manually add to the plivo/default.com
HANGUP_URL for it to work.

This is the wrong behavior.
If the plivo_answer_url is set from FS channel var then we should update the HANGUP_URL if the default one is not specified;

some cases;
NO HANGUP_URL specified

1. Use Default Answer URL or plivo_answer_url channel variable

HANGUP_URL specified
2. Do not overwrite with FS channel variable

HANGUP_URL passed from FS
overides everything

I think this is done; but its not working in my test scenario

[mike-plivo]

ok I have modified the resolution order for Answer and Hangup Urls in the last commit :

1. For Outbound Calls (calls make from REST Api with Call or BulkCalls) :

   answer url resolution order :

    -  get plivo_transfer_url from channel var
    -  get plivo_answer_url from channel var
   

   hangup url is not set because it is handled by in rest api

2. For Inbound Calls :

   answer url resolution order :

    - get plivo_transfer_url from channel var
    - get plivo_answer_url from channel var
    - get default answer_url from config
   

   hangup url resolution order :

    - get plivo_hangup_url from channel var if found
    - get default_hangup_url from config if found
    - get plivo_answer_url from channel var if found
    - get default_answer_url from config if found
   

[mike-plivo]

any feedback ?

[whitebook]

Seems good. Although new bug as of today which I fixed not regarding this; I opened another comment.