Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateWidget, DatetimeWidget (pick-a-date) now able to clear previous #59

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

seanupton
Copy link
Member

values; fixes inability to clear an already set date or datetime in Archetypes fields.

values; fixes inability to clear an already set date or datetime in
Archetypes fields.
@seanupton seanupton added this to the Plone 5.1 milestone Jul 22, 2016
@seanupton
Copy link
Member Author

I am unsure if this is something we want to also fix for the 1.10.x branch and Plone 5.0.x, as well? Thoughts?

@jensens
Copy link
Sponsor Member

jensens commented Aug 1, 2016

You can always start a Jenkins test-job on your own to test that your pull request (PR) does not break anything.

Below click on the link to Jenkins
screenshot from 2016-07-25 11 20 06

log in with your Github user - if not already done before.

Paste the full pull request URL into the text field (if multiple pull requests need to be combined in one run, then one PR URL per line)

Click on Build

Jenkins reports back to the pull request(s) on Github in the status box at the bottom.

In Plone we value a lot our testing suite, so we usually never merge pull requests if they have not been tested by Jenkins first.

@jensens
Copy link
Sponsor Member

jensens commented Aug 1, 2016

A fix for 5.0.x would be nice to have, but I think its nothing critical.

@seanupton
Copy link
Member Author

@jensens @thet @vangheem ... or anyone familiar with mockup widgets and converters for them. Anyone willing to review/merge? Checks pass, and if this gets merged, I can move on to implementing this fix (clearing previous dates with no value) for 5.0.x next.

@vangheem vangheem merged commit fd14d46 into plone:master Aug 11, 2016
@vangheem
Copy link
Member

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants