New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.app.multilingual and archetypes.multilingual have test isolation issues #447

Open
tisto opened this Issue Apr 21, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@tisto
Member

tisto commented Apr 21, 2015

Adding either plone.app.multilingual or archetypes.multilingual to the AT_plone_app_testing alltests group in buildout.coredev (tests.cfg) leads to multiple test isolation issues. Both packages seem to have test isolation problems that need to be fixed.

cc @bloodbare

@bloodbare

This comment has been minimized.

Show comment
Hide comment
@bloodbare

bloodbare Apr 21, 2015

Member

Which JK job I can check for that ?

Member

bloodbare commented Apr 21, 2015

Which JK job I can check for that ?

@tisto

This comment has been minimized.

Show comment
Hide comment
@tisto

tisto Apr 21, 2015

Member

We do not have a Jenkins job. I just tried that locally on my machine. I guess we could create a plip job. Not sure if that's worth the effort though.

Member

tisto commented Apr 21, 2015

We do not have a Jenkins job. I just tried that locally on my machine. I guess we could create a plip job. Not sure if that's worth the effort though.

@tisto

This comment has been minimized.

Show comment
Hide comment
@tisto

tisto Apr 21, 2015

Member

btw: here is the traceback for archetypes.multilingual: plone/archetypes.multilingual#12 (comment)

Member

tisto commented Apr 21, 2015

btw: here is the traceback for archetypes.multilingual: plone/archetypes.multilingual#12 (comment)

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Apr 22, 2015

Contributor

@tisto I'm just looking at https://github.com/plone/buildout.coredev/blob/5.0/tests.cfg and given my not so depth knowledge about buildout, can we actually just override some groups on another cfg file?

My idea given @bloodbare question (which jenkins job should I look at for test failures) would be to create a jenkins job for some test isolation problems, so anyone can work on them, see the errors that are happening and just update the cfg file with their pull request branches, test those branches via jenkins and merge on the build is green.

Contributor

gforcada commented Apr 22, 2015

@tisto I'm just looking at https://github.com/plone/buildout.coredev/blob/5.0/tests.cfg and given my not so depth knowledge about buildout, can we actually just override some groups on another cfg file?

My idea given @bloodbare question (which jenkins job should I look at for test failures) would be to create a jenkins job for some test isolation problems, so anyone can work on them, see the errors that are happening and just update the cfg file with their pull request branches, test those branches via jenkins and merge on the build is green.

@gforcada

This comment has been minimized.

Show comment
Hide comment
@gforcada

gforcada Apr 22, 2015

Contributor

@tisto @bloodbare it seems you can actually do it:

[buildout]
extends =
    ../core.cfg

[test-groups]
AT_plone_app_testing =
    plone.app.collection
    Products.contentmigration
    Products.CMFDynamicViewFTI
    plone.app.multilingual

@tisto all test isolation problems are documented on test.cfg?

Contributor

gforcada commented Apr 22, 2015

@tisto @bloodbare it seems you can actually do it:

[buildout]
extends =
    ../core.cfg

[test-groups]
AT_plone_app_testing =
    plone.app.collection
    Products.contentmigration
    Products.CMFDynamicViewFTI
    plone.app.multilingual

@tisto all test isolation problems are documented on test.cfg?

@vangheem vangheem added this to the Future milestone Jul 17, 2015

@do3cc

This comment has been minimized.

Show comment
Hide comment
@do3cc

do3cc Feb 17, 2016

Member

plone/plone.testing#19
More test isolation packages

Member

do3cc commented Feb 17, 2016

plone/plone.testing#19
More test isolation packages

@gforcada gforcada changed the title from plone.app.multilingual and archetypes.multilingual have test isolation issues. to plone.app.multilingual and archetypes.multilingual have test isolation issues Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment